refactor!: replace expand property with expandMaster and expandDetail#11521
Merged
Conversation
Replace the string-valued `expand` property ('master' | 'detail' | 'both')
with two independent boolean properties: `expandMaster` / `expand-master`
and `expandDetail` / `expand-detail`. Both default to false, so master
and detail areas no longer expand by default.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
fix/mdl-expand-master-detail-attrs
branch
from
f0ed154 to
d8ead72
Compare
vursen
changed the title
vursen
changed the title
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
web-padawan
approved these changes
Apr 20, 2026
isipkh110
pushed a commit
to isipkh110/flow-components
that referenced
this pull request
Apr 23, 2026
…aadin#9156) ## Description Follow-up to the web component change vaadin/web-components#11521 Replaces the `expand` enum-valued attribute on `MasterDetailLayout` with two independent boolean properties: - Removes the `ExpandingArea` enum and `get/setExpandingArea` methods - Adds `isExpandMaster` / `setExpandMaster(boolean)` (defaults to `false`) - Adds `isExpandDetail` / `setExpandDetail(boolean)` (defaults to `false`) - Drops the `ExpandingArea` parameter from the two convenience constructors; callers configure expansion via the new setters Part of vaadin/web-components#11519 ## Type of change - Refactor Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the string-valued
expandproperty ('master' | 'detail' | 'both') onvaadin-master-detail-layoutwith two independent boolean properties:expandMaster/expand-masterandexpandDetail/expand-detail. Both default tofalse, so master and detail areas no longer expand by default.Part of #11519
Type of change