fix: do not override disabled breadcrumbs item color in overlay#11807
Merged
Conversation
web-padawan
force-pushed
the
fix-disabled-overlay-item-color
branch
from
7ada147 to
1f52f35
Compare
vursen
approved these changes
May 25, 2026
web-padawan
force-pushed
the
fix-disabled-overlay-item-color
branch
from
1f52f35 to
7997f45
Compare
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-beta2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an item with
disabledset is collapsed into the overflow overlay, its link is rendered withcolor: var(--vaadin-text-color)(base) orcolor: var(--lumo-body-text-color)(Lumo), instead of the disabled text color set elsewhere on:host([disabled]) [part='link']. The override happens because the:host([slot='overlay']) [part='link']rule unconditionally re-asserts the color.Fix
colordeclaration on the overlay-slotted link to:not([disabled])so the disabled rule keeps winning the cascade.:not([disabled])guard on the equivalent rule.Visual coverage
Modified the
overflow-openedvisual tests in base / Lumo / Aura to use a 4-item fixture with the second middle item markeddisabled, to show the overlay with two collapsed items: the first focused, the second disabled.🤖 Generated with Claude Code