refactor: update breadcrumbs base styles, Lumo and Aura themes#11868
Merged
Conversation
dee184f to
fc3e162
Compare
95519ad to
d447d72
Compare
web-padawan
reviewed
Jun 2, 2026
web-padawan
left a comment
Member
There was a problem hiding this comment.
Pushed an update to the spec to list new custom CSS properties, also fixed JSDoc.
I'll continue reviewing the actual implementation later and update specs if needed.
This was referenced Jun 3, 2026
c402c48 to
2265054
Compare
This was referenced Jun 8, 2026
326fcb0 to
286ef16
Compare
82e5099 to
97a6f17
Compare
e7ab404 to
82e5099
Compare
Spec's CSS custom property tables align with the JSDoc on both elements: nine container-level tokens (typography, color, gap, two mask-image icons + size) and two item-level tokens (border radius, item gap). The separator hook is `--vaadin-breadcrumbs-separator-icon` across spec references; KDD #5, the overflow-separator bullet, and the item separator-rendering bullet are updated accordingly. Added Discussion entry explaining the token shape.
Remove --vaadin-breadcrumb-separator-icon-size
82e5099 to
adc86d5
Compare
web-padawan
approved these changes
Jun 11, 2026
web-padawan
left a comment
Member
There was a problem hiding this comment.
LGTM. Let's merge this as is and make other changes in follow-up PRs if needed.
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-beta3. |
github-merge-queue Bot
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Jun 18, 2026
The web component ships `primary` (Lumo) and `accent` (Aura) link-color theme variants, but `BreadcrumbsVariant` only exposed `SLASH`. Added missing `LUMO_PRIMARY` (`primary`) and `AURA_ACCENT` (`accent`) variants. Related to vaadin/web-components#11868 --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is how I would want the component styles to be. Not sure what we need to change in the specs to get closer to this.
Changes on a high level
…character.--vaadin-breadcrumbs-*custom properties for easier customization.accentandprimary, respectively) for coloring the links, which makes it possible to distinguish between link and non-link items without interacting with them.slashvariant to base styles, which changes the default separator icon from a chevron to a slash.