Skip to content

docs: deduplicate separator rendering in breadcrumbs spec#11887

Merged
web-padawan merged 1 commit into
mainfrom
docs/breadcrumbs-spec-separator-dedup
Jun 4, 2026
Merged

docs: deduplicate separator rendering in breadcrumbs spec#11887
web-padawan merged 1 commit into
mainfrom
docs/breadcrumbs-spec-separator-dedup

Conversation

@web-padawan

@web-padawan web-padawan commented Jun 3, 2026

Copy link
Copy Markdown
Member

Description

Improved breadcrumbs web component spec for readability.

Problem

3 sections describe the same things. Currently, the spec tells most stories three times — once in Key Design Decisions (§6, §7, §8…), once in the per-element "Internal behavior" bullets, and once in Discussion. Each layer was written to stand alone, so they restate rather than cross-reference. The separator recipe (mask-image + currentColor + RTL scaleX(-1), driven by --vaadin-breadcrumbs-separator) was spelled out in full four times: Decision, the item's "Separator rendering" bullet, a standalone "RTL separator flip" bullet, and the container's "Overflow separator" bullet.

Suggested channge

  • Updated the item's "Separator rendering" bullet to be the single canonical recipe.
  • Merged the standalone "RTL separator flip" bullet into it.
  • Reduced Decision 5 and the container's "Overflow separator" bullet to short pointers, so both list-flow elements reference one recipe instead of repeating it.

No behavior described in the spec changes, so per the spec's editing rules no new Discussion entry is added.


🤖 Generated with Claude Code

@web-padawan web-padawan changed the title docs: deduplicate separator recipe in breadcrumbs spec docs: deduplicate separator rendering in breadcrumbs spec Jun 3, 2026
@web-padawan web-padawan requested a review from yuriy-fix June 3, 2026 13:01
State the separator recipe (mask-image + currentColor + RTL flip) once in the
item's "Separator rendering" bullet and have Decision #5 and the container's
"Overflow separator" bullet point to it. Fold the standalone RTL flip bullet
into the recipe. No decisions or behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@web-padawan web-padawan force-pushed the docs/breadcrumbs-spec-separator-dedup branch from 4f5468b to 28ae9a8 Compare June 4, 2026 06:22
@web-padawan web-padawan removed the request for review from yuriy-fix June 4, 2026 06:23
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@web-padawan web-padawan merged commit 4045787 into main Jun 4, 2026
10 checks passed
@web-padawan web-padawan deleted the docs/breadcrumbs-spec-separator-dedup branch June 4, 2026 06:27
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.2.0-beta2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants