fix: apply breadcrumbs link color custom property to overlay items#11924
Merged
Conversation
Drop the `:host([slot='overlay']:not([disabled])) [part='link']` rule in item base styles that set overlay link items to the primary text color directly, overriding the `--vaadin-breadcrumbs-link-color` knob that the `[part='link']:any-link` rule uses. With it gone, overlay link items resolve through the same knob as trail links, so the `theme="primary"` / `theme="accent"` variants apply to overlay links too. Move the Lumo `primary` and Aura `accent` visual tests under the overflow describe and open the overlay before the diff so the new behavior is covered.
…ems in Lumo Drop the Lumo `:host([slot='overlay']:not([disabled])) [part='link']` side of the overlay color rule. It was setting overlay link items to `--lumo-body-text-color` directly, overriding the `--vaadin-breadcrumbs-link-color` knob so the `theme="primary"` variant could not color overlay links. The rule still applies to `[part='nolink']` so non-link overlay items keep the body text color.
jouni
approved these changes
Jun 11, 2026
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-beta3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #11900
Fixed a small regression compared to the original base styles & themes PR.
Type of change