LazyLoad: Add external web platform tests for the "loading" attribute.#14914
Merged
Conversation
wpt-pr-bot
approved these changes
Jan 17, 2019
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
Already reviewed downstream.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
from
731a86d to
69ba0d4
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
2 times, most recently
from
3b29d61 to
b6b0fd5
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
from
b6b0fd5 to
490f60b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
2 times, most recently
from
6f16773 to
8230c5d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
2 times, most recently
from
00d84a6 to
39546ea
Compare
This CL includes tests for: - Testing that images and iframes with the attribute loading="lazy" are deferred until they come into view - Testing that images and iframes with the attribute loading="eager" are loaded immediately Bug: 916260 Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#676804}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1417117
branch
from
39546ea to
9774518
Compare
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 12, 2020
Follow-up: #5236. Tests: * web-platform-tests/wpt#14914 * web-platform-tests/wpt#17985 * web-platform-tests/wpt#18087 * web-platform-tests/wpt#20634 * web-platform-tests/wpt#20747 * web-platform-tests/wpt#20683 * web-platform-tests/wpt#20774 * web-platform-tests/wpt#20680 * Some as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Closes #2806. Closes #5250. Co-authored-by: Dominic Farolino <domfarolino@gmail.com> Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL includes tests for:
deferred until they come into view
loaded immediately
Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}