Add [Exposed=*] to expose on all globals#526

littledan · 2018-02-22T16:27:24Z

This patch adds support in WebIDL for declaring an interface available
in all contexts.

Closes #468

This PR follows the syntax and outline suggested by @tobie . Thanks for your clear instructions here.

annevk · 2018-02-23T13:55:51Z

I think before landing this we should try to address the question at #468 (comment).

littledan · 2018-02-23T19:01:27Z

@annevk Thanks for making this link. I think we should work out an answer in conjunction with TC39 to this question, given that ECMAScript includes things that are pretty equivalent in power/appropriateness to put everywhere to TextEncoder and URL. I'm fine with letting this PR be blocked on this question.

littledan · 2018-10-20T17:34:26Z

We should include the jsidl label on this issue, since all ES APIs will need to be exposed to all globals

leobalter · 2021-09-22T16:22:13Z

@littledan I believe we should follow up on this PR for the proper ShadowRealms integration, right?

littledan · 2021-09-22T17:18:47Z

We could add this for ShadowRealms, or we could just add [Exposed=ShadowRealm]. The choice depends on whether we want to go around adding lots of things to Worklets which are not currently exposed, and which we might decide to expose on ShadowRealm. In offline conversations with different HTML editors, I heard mixed opinions on this question, cc @domenic @annevk . Given that, I thought that it might be better to start with the more conservative approach of just adding things specifically to ShadowRealm.

domenic · 2021-09-22T19:20:09Z

I think it'd be better to add [Exposed=*]? Saying that in worklets you have to access these APIs indirectly via shadow realms seems strange.

annevk · 2021-09-23T07:06:36Z

In an offline discussion tc39/ecma262#1120 came up, but since we did not change JavaScript to support minimal realms (i.e., a subset of what is defined in JavaScript), we should not do so here by excluding worklets. (As that would make worklets the new minimal realms due to organizational boundaries.)

As I understand it the primary motivation for having minimal realms in worklets was to avoid steering web developers down the wrong path, but in practice this hasn't been much of a problem.

This is a long way of saying that I agree with @domenic, but I thought it might be useful to add some context.

cc @padenot @codehag @Ms2ger

littledan · 2021-09-23T09:38:52Z

OK, thanks for the clarifications everyone, sounds like I was the confused/misunderstanding one. Does that mean we should move ahead with [Exposed=*]?

This patch adds support in WebIDL for declaring an interface available in all contexts. Closes whatwg#468

Ms2ger · 2021-10-01T09:36:02Z

Rebased and rephrased a bit - what's next here?

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>

EdgarChen

Looks good to me, thanks!

EdgarChen · 2021-11-01T10:49:39Z

@Ms2ger it would be helpful if you could make a list of interfaces which [Exposed=*] is proposed somewhere publicly. Thanks!

TimothyGu

Looks good!

Ms2ger · 2021-11-02T12:55:55Z

@Ms2ger it would be helpful if you could make a list of interfaces which [Exposed=*] is proposed somewhere publicly. Thanks!

Besides the ones already listed in tc39/proposal-shadowrealm#331, we might propose some parts of Crypto and Performance - please do let me know if you'd like me to present the list in some other way

https://bugs.webkit.org/show_bug.cgi?id=231082 Reviewed by Chris Dumez. Adds a shorthand to expose interfaces/attributes on Window, Workers*, and the forthcoming ShadowRealm global object. See whatwg/webidl#468 and whatwg/webidl#526 for details. * bindings/scripts/CodeGenerator.pm: (shouldPropertyBeExposed): * bindings/scripts/CodeGeneratorJS.pm: (GenerateRuntimeEnableConditionalStringForExposed): * bindings/scripts/IDLParser.pm: (parseExtendedAttributeRest2): * bindings/scripts/preprocess-idls.pl: * bindings/scripts/test/AudioWorkletGlobalScopeConstructors.idl: * bindings/scripts/test/DOMWindowConstructors.idl: * bindings/scripts/test/DedicatedWorkerGlobalScopeConstructors.idl: * bindings/scripts/test/ExposedStar.idl: Added. * bindings/scripts/test/JS/JSDOMWindow.cpp: (WebCore::jsDOMWindow_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp: (WebCore::jsDedicatedWorkerGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSExposedStar.cpp: Added. (WebCore::JSExposedStarDOMConstructor::prototypeForStructure): (WebCore::JSExposedStarDOMConstructor::initializeProperties): (WebCore::JSExposedStarPrototype::finishCreation): (WebCore::JSExposedStar::JSExposedStar): (WebCore::JSExposedStar::finishCreation): (WebCore::JSExposedStar::createPrototype): (WebCore::JSExposedStar::prototype): (WebCore::JSExposedStar::getConstructor): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::jsExposedStarPrototypeFunction_operationForAllContextsBody): (WebCore::JSC_DEFINE_HOST_FUNCTION): (WebCore::jsExposedStarPrototypeFunction_operationJustForWindowContextsBody): (WebCore::jsExposedStarPrototypeFunction_operationJustForWorkerContextsBody): (WebCore::JSExposedStar::subspaceForImpl): (WebCore::JSExposedStar::analyzeHeap): (WebCore::toJSNewlyCreated): (WebCore::toJS): (WebCore::JSExposedStar::toWrapped): * bindings/scripts/test/JS/JSExposedStar.h: Added. (WebCore::JSExposedStar::create): (WebCore::JSExposedStar::createStructure): (WebCore::JSExposedStar::subspaceFor): (WebCore::JSExposedStar::wrapped const): (WebCore::toJS): (WebCore::toJSNewlyCreated): * bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp: (WebCore::jsPaintWorkletGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp: (WebCore::jsServiceWorkerGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/PaintWorkletGlobalScopeConstructors.idl: * bindings/scripts/test/ServiceWorkerGlobalScopeConstructors.idl: * bindings/scripts/test/SupplementalDependencies.dep: Canonical link: https://commits.webkit.org/243822@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=231082 Reviewed by Chris Dumez. Adds a shorthand to expose interfaces/attributes on Window, Workers*, and the forthcoming ShadowRealm global object. See whatwg/webidl#468 and whatwg/webidl#526 for details. * bindings/scripts/CodeGenerator.pm: (shouldPropertyBeExposed): * bindings/scripts/CodeGeneratorJS.pm: (GenerateRuntimeEnableConditionalStringForExposed): * bindings/scripts/IDLParser.pm: (parseExtendedAttributeRest2): * bindings/scripts/preprocess-idls.pl: * bindings/scripts/test/AudioWorkletGlobalScopeConstructors.idl: * bindings/scripts/test/DOMWindowConstructors.idl: * bindings/scripts/test/DedicatedWorkerGlobalScopeConstructors.idl: * bindings/scripts/test/ExposedStar.idl: Added. * bindings/scripts/test/JS/JSDOMWindow.cpp: (WebCore::jsDOMWindow_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp: (WebCore::jsDedicatedWorkerGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSExposedStar.cpp: Added. (WebCore::JSExposedStarDOMConstructor::prototypeForStructure): (WebCore::JSExposedStarDOMConstructor::initializeProperties): (WebCore::JSExposedStarPrototype::finishCreation): (WebCore::JSExposedStar::JSExposedStar): (WebCore::JSExposedStar::finishCreation): (WebCore::JSExposedStar::createPrototype): (WebCore::JSExposedStar::prototype): (WebCore::JSExposedStar::getConstructor): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::jsExposedStarPrototypeFunction_operationForAllContextsBody): (WebCore::JSC_DEFINE_HOST_FUNCTION): (WebCore::jsExposedStarPrototypeFunction_operationJustForWindowContextsBody): (WebCore::jsExposedStarPrototypeFunction_operationJustForWorkerContextsBody): (WebCore::JSExposedStar::subspaceForImpl): (WebCore::JSExposedStar::analyzeHeap): (WebCore::toJSNewlyCreated): (WebCore::toJS): (WebCore::JSExposedStar::toWrapped): * bindings/scripts/test/JS/JSExposedStar.h: Added. (WebCore::JSExposedStar::create): (WebCore::JSExposedStar::createStructure): (WebCore::JSExposedStar::subspaceFor): (WebCore::JSExposedStar::wrapped const): (WebCore::toJS): (WebCore::toJSNewlyCreated): * bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp: (WebCore::jsPaintWorkletGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp: (WebCore::jsServiceWorkerGlobalScope_ExposedStarConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * bindings/scripts/test/PaintWorkletGlobalScopeConstructors.idl: * bindings/scripts/test/ServiceWorkerGlobalScopeConstructors.idl: * bindings/scripts/test/SupplementalDependencies.dep: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@285196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

littledan · 2022-06-07T22:31:20Z

This change looks great, but I don't think it handles the ShadowRealm case yet, since that is not an interface.

annevk · 2022-06-08T06:50:42Z

@littledan that's a good point. I suppose we should put that requirement in HTML along with the overall ShadowRealm integration?

tobie reviewed Feb 22, 2018

View reviewed changes

Comment thread index.bs Outdated

Comment thread index.bs Outdated

littledan force-pushed the exposed-star branch from f3b99aa to f0f2125 Compare February 23, 2018 13:50

tobie reviewed Feb 23, 2018

View reviewed changes

Comment thread index.bs Outdated

tobie reviewed Feb 23, 2018

View reviewed changes

Comment thread index.bs Outdated

littledan force-pushed the exposed-star branch 2 times, most recently from 35b291d to 2e23cfb Compare February 23, 2018 14:42

tobie added the do not merge yet Pull request must not be merged per rationale in comment label Feb 26, 2018

littledan mentioned this pull request Oct 20, 2018

[JS] Wasm and worklets WebAssembly/spec#570

Closed

tobie added the jsidl label Oct 20, 2018

leobalter mentioned this pull request Sep 22, 2021

Path to Stage 4 tc39/proposal-shadowrealm#4

Open

22 tasks

This comment has been minimized.

Sign in to view

Add [Exposed=*] to expose on all globals

c330ccd

This patch adds support in WebIDL for declaring an interface available in all contexts. Closes whatwg#468

Ms2ger force-pushed the exposed-star branch from 2e23cfb to c330ccd Compare October 1, 2021 08:10

fixup! Add [Exposed=*] to expose on all globals

aa3e328

ExE-Boss reviewed Oct 1, 2021

View reviewed changes

Comment thread index.bs Outdated

Update index.bs

bde135a

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>

Ms2ger requested a review from annevk October 7, 2021 15:04

annevk requested review from EdgarChen and removed request for annevk October 8, 2021 10:24

EdgarChen approved these changes Oct 8, 2021

View reviewed changes

Ms2ger requested a review from TimothyGu October 12, 2021 08:40

Ms2ger mentioned this pull request Oct 12, 2021

Expose some Web APIs on ShadowRealms tc39/proposal-shadowrealm#331

Closed

14 tasks

This was referenced Oct 15, 2021

Expose everywhere whatwg/streams#1176

Merged

Expose everywhere whatwg/compression#40

Merged

saschanaz mentioned this pull request Oct 29, 2021

Expose everywhere w3c/hr-time#130

Merged

4 tasks

TimothyGu approved these changes Nov 1, 2021

View reviewed changes

saschanaz mentioned this pull request Nov 2, 2021

Add shadowrealm.d.ts and make others depend on it microsoft/TypeScript-DOM-lib-generator#1191

Open

EdgarChen removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 2, 2021

EdgarChen merged commit 59dae6f into whatwg:main Nov 2, 2021

This was referenced Nov 2, 2021

Deploy failure #1057

Closed

feat: support [Exposed=*] w3c/webidl2.js#634

Merged

dontcallmedom mentioned this pull request Jan 20, 2022

📦 Release @webref/idl@3.0.0 w3c/webref#457

Merged

legendecas mentioned this pull request Mar 30, 2022

ShadowRealm Integration nodejs/node#42528

Open

ptomato mentioned this pull request Aug 22, 2024

New Principle: Use [Exposed=*] to make only purely computational APIs available w3ctag/design-principles#509

Closed

Uh oh!

Conversation

littledan commented Feb 22, 2018 • edited by pr-preview Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

annevk commented Feb 23, 2018

Uh oh!

Uh oh!

Uh oh!

littledan commented Feb 23, 2018

Uh oh!

littledan commented Oct 20, 2018

Uh oh!

leobalter commented Sep 22, 2021

Uh oh!

littledan commented Sep 22, 2021

Uh oh!

This comment has been minimized.

domenic commented Sep 22, 2021

Uh oh!

annevk commented Sep 23, 2021

Uh oh!

littledan commented Sep 23, 2021

Uh oh!

Ms2ger commented Oct 1, 2021

Uh oh!

Uh oh!

EdgarChen left a comment

Choose a reason for hiding this comment

Uh oh!

EdgarChen commented Nov 1, 2021

Uh oh!

TimothyGu left a comment

Choose a reason for hiding this comment

Uh oh!

Ms2ger commented Nov 2, 2021

Uh oh!

littledan commented Jun 7, 2022

Uh oh!

annevk commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

9 participants

littledan commented Feb 22, 2018 •

edited by pr-preview Bot

Loading