docs/deprecated: legacy links env vars #6263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vvoland
reviewed
Aug 14, 2025
docs/deprecated.md
Outdated
Comment on lines
138
to
139
| Starting in Docker v29.0, these environment variables are deprecated, and won't be | ||
| added auomtatically anymore. Users who still depend on them can start Docker Engine |
Collaborator
There was a problem hiding this comment.
Suggested change
| Starting in Docker v29.0, these environment variables are deprecated, and won't be | |
| added auomtatically anymore. Users who still depend on them can start Docker Engine | |
| Starting with Docker v29.0, these environment variables are deprecated and will no longer be added automatically. Users who still depend on them can start Docker Engine |
Member
There was a problem hiding this comment.
I'd be fine to disable it by default in v28.4, and remove the feature in v29 (or v30 depending on how much effort) - the legacy links were already deprecated since "forever", just never removed the functionality.
Member
thaJeztah
force-pushed
the
deprecate-legacy-links-env-vars
branch
from
c1934ce to
1c6c38d
Compare
Member
|
@akerouanton I did a quick rebase and pushed a temporary commit with some suggestions so that we can cherry-pick the deprecation to 28.4; i.e., the deprecation itself will be in v28.4 (but no changes yet) and v29.0 can disable the option by default (removing it in v30); let me know if it LGTY, then I can squash the commits. |
akerouanton
force-pushed
the
deprecate-legacy-links-env-vars
branch
from
1c6c38d to
3a31132
Compare
Signed-off-by: Albin Kerouanton <[email protected]> Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
akerouanton
force-pushed
the
deprecate-legacy-links-env-vars
branch
from
3a31132 to
5c76f7f
Compare
Member
Author
|
LGTM — I squashed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did