-
-
Notifications
You must be signed in to change notification settings - Fork 89
fix(nestjs): allow Express 5 peer dependency for NestJS 11 #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nestjs): allow Express 5 peer dependency for NestJS 11 #493
Conversation
Summary of ChangesHello @crohasang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly relaxes the express peer dependency for @fedify/nestjs to ^4.0.0 || ^5.0.0, enabling compatibility with NestJS 11 and Express 5. The change is well-documented in CHANGES.md. I have one minor suggestion to improve formatting consistency in the changelog.
| - Allowed Express 5 in the `express` peer dependency range to support NestJS 11. | ||
| [[#492], [#493] by Cho Hasang] | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
NestJS 11 environments may use Express 5. This PR relaxes fedify/nestjs’s express peer dependency range so projects on Express 5 can install and use the NestJS integration without peer dependency conflicts.
Related Issue
Changes
Widened peerDependencies.express to ^4.0.0 || ^5.0.0
Benefits
Checklist
deno task test-allon your machine?