Skip to content

Conversation

@crohasang
Copy link
Contributor

Summary

NestJS 11 environments may use Express 5. This PR relaxes fedify/nestjs’s express peer dependency range so projects on Express 5 can install and use the NestJS integration without peer dependency conflicts.

Related Issue

Changes

Widened peerDependencies.express to ^4.0.0 || ^5.0.0

Benefits

  • fedify/nestjs can be used in NestJS 11 + Express 5 projects.
  • Keeps workspace catalog pinned to Express 4 for internal development/test stability, while still allowing Express 5 in consuming applications.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @crohasang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues for the @fedify/nestjs package by relaxing its express peer dependency. The primary goal is to enable projects using NestJS 11 with Express 5 to install and utilize the integration without encountering peer dependency conflicts, thereby broadening the package's usability in modern NestJS environments.

Highlights

  • Peer Dependency Update: The express peer dependency for the @fedify/nestjs package has been updated to allow compatibility with both Express 4 and Express 5.
  • NestJS 11 Compatibility: This change ensures that @fedify/nestjs can be seamlessly integrated into projects utilizing NestJS 11, which may now use Express 5, resolving potential peer dependency conflicts during installation.
  • Internal Stability Maintained: While broadening external compatibility, the update strategically maintains internal development and test stability by keeping the workspace catalog pinned to Express 4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly relaxes the express peer dependency for @fedify/nestjs to ^4.0.0 || ^5.0.0, enabling compatibility with NestJS 11 and Express 5. The change is well-documented in CHANGES.md. I have one minor suggestion to improve formatting consistency in the changelog.

- Allowed Express 5 in the `express` peer dependency range to support NestJS 11.
[[#492], [#493] by Cho Hasang]


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This extra blank line can be removed to maintain consistency with other entries in the changelog, which typically have only one blank line between the change description and its reference links.

@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dahlia dahlia merged commit 95c2c5f into fedify-dev:main Dec 13, 2025
10 checks passed
@dahlia dahlia added the integration/nestjs NestJS integration (@fedify/nestjs) label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration/nestjs NestJS integration (@fedify/nestjs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@fedify/nestjs: Peer dependency only allows express ^4, but NestJS 11 uses express 5

2 participants