inspector: coerce key and value to string in webstorage events#62616
Closed
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Closed
inspector: coerce key and value to string in webstorage events#62616thisalihassan wants to merge 1 commit intonodejs:mainfrom
thisalihassan wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
inspector
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62616 +/- ##
==========================================
+ Coverage 89.75% 89.78% +0.03%
==========================================
Files 696 696
Lines 214812 214818 +6
Branches 41108 41116 +8
==========================================
+ Hits 192801 192876 +75
+ Misses 14120 14030 -90
- Partials 7891 7912 +21
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Apr 6, 2026
Collaborator
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Collaborator
Member
|
Landed in 449a93a |
thisalihassan
added a commit
to thisalihassan/node
that referenced
this pull request
May 7, 2026
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com> PR-URL: nodejs#62616 Refs: nodejs#62145 Refs: nodejs#62162 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's this test is failing everywhere, I can also produce this on local
test-inspector-dom-storage
parallel
duration_ms: 86.899
exitcode: 1
severity: fail
stack: |-
Debugger listening on ws://127.0.0.1:35101/9a738d12-0f90-4667-8875-1f17ef781521
For help, see: https://nodejs.org/en/docs/inspector
node:inspector:212
emitProtocolEvent(eventName, params);
^
TypeError: Missing newValue in event
at broadcastToFrontend (node:inspector:212:3)
at Object.domStorageItemAdded (node:inspector:233:36)
at itemAdded (node:internal/inspector/webstorage:53:14)
at InspectorLocalStorage.setItem (node:internal/inspector/webstorage:13:7)
at test (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-inspector-dom-storage.js:75:16)
at async testGetData (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-inspector-dom-storage.js:62:3)
at async test (/home/iojs/build/workspace/node-test-commit-linuxone/test/parallel/test-inspector-dom-storage.js:167:3)
Refs: #62145
Refs: #62162