Skip to content

stream: remove duplicated utility#63031

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:remove-duplicate-non-writable-util
May 4, 2026
Merged

stream: remove duplicated utility#63031
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:remove-duplicate-non-writable-util

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 29, 2026

And reorder the object keys in ASCII-order (only a few were slightly off, couldn't help myself)

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (2a601eb) to head (d76d371).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63031      +/-   ##
==========================================
- Coverage   89.65%   89.64%   -0.02%     
==========================================
  Files         708      708              
  Lines      220374   220356      -18     
  Branches    42264    42262       -2     
==========================================
- Hits       197584   197539      -45     
- Misses      14656    14681      +25     
- Partials     8134     8136       +2     
Files with missing lines Coverage Δ
lib/internal/webstreams/queuingstrategies.js 100.00% <100.00%> (ø)
lib/internal/webstreams/readablestream.js 98.54% <100.00%> (-0.01%) ⬇️
lib/internal/webstreams/transformstream.js 98.55% <100.00%> (-0.02%) ⬇️
lib/internal/webstreams/util.js 99.57% <100.00%> (+0.01%) ⬆️
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (-0.01%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 1, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2026
@nodejs-github-bot nodejs-github-bot merged commit 266cd67 into nodejs:main May 4, 2026
86 checks passed
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 4, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/63031
✔  Done loading data for nodejs/node/pull/63031
----------------------------------- PR info ------------------------------------
Title      stream: remove duplicated utility (#63031)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:remove-duplicate-non-writable-util -> nodejs:main
Labels     lib / src, author ready, needs-ci
Commits    1
 - stream: remove duplicated utility
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Apr 2026 09:52:23 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63031#pullrequestreview-4211377766
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63031#pullrequestreview-4221332527
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-04T14:59:10Z: https://ci.nodejs.org/job/node-test-pull-request/73092/
- Querying data for job/node-test-pull-request/73092/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63031
From https://github.com/nodejs/node
 * branch                  refs/pull/63031/merge -> FETCH_HEAD
✔  Fetched commits as 25f80fb7647d..d76d3716b1a0
--------------------------------------------------------------------------------
Auto-merging lib/internal/webstreams/util.js
[main 129daec137] stream: remove duplicated utility
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Wed Apr 29 11:50:07 2026 +0200
 5 files changed, 33 insertions(+), 51 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
stream: remove duplicated utility

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[main 3d6d64281a] stream: remove duplicated utility
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Wed Apr 29 11:50:07 2026 +0200
5 files changed, 33 insertions(+), 51 deletions(-)
✔ 3d6d64281ada113e938640e3a7d0038358379974
✔ 0:0 no Assisted-by metadata assisted-by-is-trailer
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 2:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 has valid Signed-off-by signed-off-by
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

The following commits are landable on origin/main

  • 3d6d64281a stream: remove duplicated utility

  • Removing temporary files
    ✔ Temporary files removed.
    To finish landing:
  1. Run:
    git push origin main
  2. Post "Landed in 3d6d64281ada" in stream: remove duplicated utility #63031
    gh pr comment stream: remove duplicated utility #63031 --body "Landed in 3d6d64281ada"
    gh pr close stream: remove duplicated utility #63031
https://github.com/nodejs/node/actions/runs/25329280625

@aduh95 aduh95 deleted the remove-duplicate-non-writable-util branch May 4, 2026 16:18
@aduh95 aduh95 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 4, 2026
aduh95 added a commit that referenced this pull request May 5, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request May 7, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63031
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants