windows: cross compilation fails due to headers with uppercase

[erikjanss]

BPO	34217
Nosy	@pfmoore, @tjguk, @methane, @zware, @eryksun, @zooba, @moreati, @miss-islington, @erikjanss
PRs	bpo-34217: use lowercase header for windows includes #8453 bpo-34217: Fix include "Windows.h" case for cross-compiling #8472 [3.7] bpo-34217: Use lowercase header for Windows (GH-8453) #8560 [3.7] bpo-34217: Use lowercase for windows headers (GH-8472) #8782
Files	windows_headers.py: python3 script to detect uppercases in windows headers

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-09-06.21:31:24.173>
created_at = <Date 2018-07-24.23:42:09.210>
labels = ['build', '3.8', 'OS-windows']
title = 'windows: cross compilation fails due to headers with uppercase'
updated_at = <Date 2018-09-06.21:31:24.173>
user = 'https://github.com/erikjanss'

bugs.python.org fields:

activity = <Date 2018-09-06.21:31:24.173>
actor = 'erikjanss'
assignee = 'none'
closed = True
closed_date = <Date 2018-09-06.21:31:24.173>
closer = 'erikjanss'
components = ['Windows', 'Cross-Build']
creation = <Date 2018-07-24.23:42:09.210>
creator = 'erikjanss'
dependencies = []
files = ['47751']
hgrepos = []
issue_num = 34217
keywords = ['patch']
message_count = 20.0
messages = ['322333', '322335', '322655', '323582', '323586', '323594', '323595', '323596', '323597', '323602', '323603', '323619', '323621', '323622', '323625', '323629', '323693', '323701', '323713', '323781']
nosy_count = 9.0
nosy_names = ['paul.moore', 'tim.golden', 'methane', 'zach.ware', 'eryksun', 'steve.dower', 'Alex.Willmer', 'miss-islington', 'erikjanss']
pr_nums = ['8453', '8472', '8560', '8782']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue34217'
versions = ['Python 3.8']

[erikjanss]

When cross compiling python on a linux host with a case sensitive file system for a windows target. The compilation will fail due to header
files which contain uppercases.

[methane]

New changeset 6cf8255 by INADA Naoki (erikjanss) in branch 'master':
bpo-34217: Use lowercase header for Windows (GH-8453)
6cf8255

[miss-islington]

New changeset 6c89a9a by Miss Islington (bot) in branch '3.7':
bpo-34217: Use lowercase header for Windows (GH-8453)
6c89a9a

[erikjanss]

Attached a small helper script to detect camelcase windows headers,
2 more occurences found :

Modules/socketmodule.c versionhelpers.h 306 #include <VersionHelpers.h>
Tools/msi/bundle/bootstrap/pch.h uxtheme.h 18 #include <Uxtheme.h>

[zooba]

Are those bugs? On Windows, they are spelled with that casing (and while NTFS is case-insensitive, it *is* case-preserving).

Whatever package you have used for cross-compiling may have renamed them (similarly Shlwapi.h). In which case, perhaps you could request that the package you are using preserve the case of the files it is cloning, rather than changing it?

[methane]

New changeset e6a4755 by INADA Naoki (Erik Janssens) in branch 'master':
bpo-34217: Use lowercase for windows headers (GH-8472)
e6a4755

[erikjanss]

@inada.naoki : thank you !

@steve.dower : I would not consider those bugs per se, but they are
inconsistencies, for example in the master branch :

number of "Windows.h" includes : 2
number of "windows.h" includes : 55

whatever might be the 'right' solution, it's always an advantage to
have a consistent codebase.

[methane]

New windows will support case sensitive filesystem too.
Stop relying to case insensitive filesystem makes sense to me.

[miss-islington]

New changeset bf8e9d1 by Miss Islington (bot) in branch '3.7':
bpo-34217: Use lowercase for windows headers (GH-8472)
bf8e9d1