update_one_slot() should not ignore wrapper descriptors for wrong type

[jdemeyer]

BPO	37619
Nosy	@Yhg1s, @jdemeyer
PRs	bpo-37619: don't ignore wrapper descriptors for wrong class #14836 [3.8] bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836) #15838

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-09-10.13:03:16.765>
created_at = <Date 2019-07-18.09:04:18.404>
labels = ['interpreter-core', '3.7', '3.8', '3.9']
title = 'update_one_slot() should not ignore wrapper descriptors for wrong type'
updated_at = <Date 2019-09-10.13:03:16.764>
user = 'https://github.com/jdemeyer'

bugs.python.org fields:

activity = <Date 2019-09-10.13:03:16.764>
actor = 'twouters'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-10.13:03:16.765>
closer = 'twouters'
components = ['Interpreter Core']
creation = <Date 2019-07-18.09:04:18.404>
creator = 'jdemeyer'
dependencies = []
files = []
hgrepos = []
issue_num = 37619
keywords = ['patch']
message_count = 4.0
messages = ['348108', '351623', '351633', '351637']
nosy_count = 2.0
nosy_names = ['twouters', 'jdemeyer']
pr_nums = ['14836', '15838']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37619'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']

[jdemeyer]

>>> class S(str):
...     __eq__ = int.__eq__
>>> S() == S()
True

The expectation is that this raises an exception because int.__eq__() is called on S instances.

[Yhg1s]

New changeset 57ea335 by T. Wouters (Jeroen Demeyer) in branch 'master':
bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836)
57ea335

[Yhg1s]

New changeset eb1bc48 by T. Wouters (Miss Islington (bot)) in branch '3.8':
bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-15838)
eb1bc48

[Yhg1s]

I don't think this should be backported to 3.7 at this point; if you disagree feel free to reopen the bug.