gh-99908: Tutorial: Modernize the 'data-record class' example #100499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @AlexWaygood, all checks are passing now:) |
AlexWaygood
reviewed
Dec 24, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks @JosephSBoyle, looks good! A few thoughts:
Contributor
Author
|
Thanks for the review @AlexWaygood! I believe I've resolved all of your threads. |
AlexWaygood
reviewed
Dec 24, 2022
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Dec 24, 2022
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great! Thanks @JosephSBoyle!
AlexWaygood
changed the title
AlexWaygood
added
needs backport to 3.10
Contributor
|
Thanks @JosephSBoyle for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Thanks @JosephSBoyle for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-100500 is a backport of this pull request to the 3.10 branch. |
|
GH-100501 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize an antiquated example of a 'record' class to use dataclasses.