bpo-30524: Fix _PyStack_UnpackDict()#1886
Merged
vstinner merged 1 commit intopython:3.6from Jun 9, 2017
vstinner:unpack_dict
Merged
bpo-30524: Fix _PyStack_UnpackDict()#1886vstinner merged 1 commit intopython:3.6from vstinner:unpack_dict
vstinner merged 1 commit intopython:3.6from
vstinner:unpack_dict
Conversation
methane
approved these changes
May 31, 2017
serhiy-storchaka
approved these changes
Jun 1, 2017
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. But would be nice to add a test.
Member
Author
I wrote unit tests for FASTCALL including a specific unit test for the datetime.datetime.now() specific case: #2022 The PR was written for master, but I will then backport it to Python 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notify of failure when args is NULL. _PyStack_UnpackDict() now
returns -1 on error.