Skip to content

bpo-40903: Handle multiple '=' in invalid assignment rules in the PEG parser #20697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 7 commits into from
Jun 8, 2020
Merged

bpo-40903: Handle multiple '=' in invalid assignment rules in the PEG parser #20697

miss-islington merged 7 commits into from
Jun 8, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 7, 2020 •
edited by miss-islington
Loading

@pablogsal pablogsal requested review from gvanrossum and lysnikolaou and removed request for gvanrossum June 7, 2020 22:54
gvanrossum
gvanrossum reviewed Jun 7, 2020
View reviewed changes
@stestagg
Copy link

stestagg commented Jun 8, 2020

Hi

I think I've found another one:

a=yield=1

seems to segfault even with these patches

Steve

@pablogsal
Copy link
Member Author

pablogsal commented Jun 8, 2020 •
edited
Loading

I think I've found another one:

Thanks for the catch! Handled in f259e98

gvanrossum
gvanrossum approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington miss-islington merged commit 9f49590 into python:master Jun 8, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jun 8, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 8, 2020

GH-20704 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 8, 2020
@miss-islington @pablogsal
bpo-40903: Handle multiple '=' in invalid assignment rules in the PEG…
8df4f39 
… parser (GH-20697)

Automerge-Triggered-By: @pablogsal
(cherry picked from commit 9f49590)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal deleted the bpo-40903 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @stestagg @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni