bpo-20364: Improve sqlite3 placeholder docs#25003
bpo-20364: Improve sqlite3 placeholder docs#25003berkerpeksag merged 11 commits intopython:masterfrom
Conversation
|
@berkerpeksag, @terryjreedy: would you mind taking a look at this? |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
|
Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃 |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
|
Ah, can you also fix the following error? You'll probably need to update |
|
Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right? |
|
Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
(cherry picked from commit 3386ca0) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-25402 is a backport of this pull request to the 3.9 branch. |
|
Thanks for reviewing, @berkerpeksag ! |
Co-authored-by: Terry J. Reedy
https://bugs.python.org/issue20364