[mypyc] Replace deprecated _PyDict_GetItemStringWithError#17930
Merged
JukkaL merged 2 commits intopython:masterfrom Oct 16, 2024
Merged
[mypyc] Replace deprecated _PyDict_GetItemStringWithError#17930JukkaL merged 2 commits intopython:masterfrom
JukkaL merged 2 commits intopython:masterfrom
Conversation
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Does this return a strong reference when the old one returned a borrowed reference?
JukkaL
approved these changes
Oct 16, 2024
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 28, 2024
hauntsaninja
added a commit
that referenced
this pull request
Dec 28, 2024
Fixes mypyc/mypyc#1078 Introduced in #17930 See the first commit to see the bug (wrong condition) --------- Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
svalentin
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fixes mypyc/mypyc#1078 Introduced in #17930 See the first commit to see the bug (wrong condition) --------- Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyDict_GetItemStringWithErrorwas deprecated for Python 3.14 in python/cpython#119855.Use
PyDict_GetItemStringRefinstead. It was added in 3.13 but is available viapythoncapi_compat.h.https://docs.python.org/3/c-api/dict.html#c.PyDict_GetItemStringRef