Warn adduser changes, undeprecate --auth-type, but warn for some values#5149
Merged
Warn adduser changes, undeprecate --auth-type, but warn for some values#5149
Conversation
fritzy
commented
Jul 11, 2022
- feat: notify on adduser of upcoming cmds, login and register
- feat: deprecate --auth-type=sso/saml/oauth, undeprecate --auth-type
Author
|
Please don't squash. |
Collaborator
|
found 1 benchmarks with statistically significant performance regressions
timing results
|
wraithgar
reviewed
Jul 12, 2022
wraithgar
approved these changes
Jul 12, 2022
Member
wraithgar
left a comment
There was a problem hiding this comment.
Approved w/ one tiny suggestion you can ignore if you want.
953fe84 to
d0cef40
Compare
d0cef40 to
9ca41c8
Compare
Merged
This was referenced Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.