Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Jul 21, 2025

Related issues

Proposed Changes

Testing Instructions

  • Modify your production WPcom's environment_type to development in network admin settings tab.
  • Run npm start
  • Observe your site appears in Studio
  • Open the sync modal
  • Observe the environment
  • Connect the site
  • Open the pull and push dialogs.
  • Observe the texts remain the same as before.
Screenshot 2025-07-21 at 14 35 13 Screenshot 2025-07-21 at 14 36 45 Screenshot 2025-07-21 at 14 38 28 Screenshot 2025-07-21 at 14 38 26

Before this PR the site wouldn't appear.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Jul 21, 2025
@sejas sejas changed the title Update/stu 641 studio sites with custom environment types are hidden on Support sites with custom environment types Jul 21, 2025
@sejas sejas requested a review from a team July 21, 2025 13:40
Copy link
Contributor

@gcsecsey gcsecsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas for fixing showing sites with custom environment types. The changes make sense to me, and work great, now I'm able to add my site with a custom type and pull/push to it.

I set my site's environment_type to testing:
Image

When connecting a site, the site is no longer filtered out in the site list:

trunk this branch
Image Image

The pull and push dialogs still display "Production" on the badge:

Pull Push
Image Image

@sejas sejas merged commit 32aa3cb into trunk Jul 23, 2025
12 checks passed
@sejas sejas deleted the update/stu-641-studio-sites-with-custom-environment-types-are-hidden-on branch July 23, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants