-
Notifications
You must be signed in to change notification settings - Fork 54
Sync: Update modal design #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Performance Test ResultsComparing deec66b vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
nightnei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We don't need to have so much empty space there and instead keep the modal compact. I have made the change in 85db6f5. |
Thanks for making changes, it looks good to me 👍 |
|
Thank you for your reviews, Vova and Kat! |



Related issues
Proposed Changes
This PR is a part of STU-798 task where the goal is to align designs of Staging sites Sync modal in Calypso with Sync modal in the Studio app.
Here's the related Figma design: RToz6tIuQ7nlZrikBte4GU-fi-9870_110924.
In this PR we are adjusting the Sync modal in the Studio app:
What would you like to push/pull?subtitleTesting Instructions
npm install && npm start.Pre-merge Checklist