-
Notifications
You must be signed in to change notification settings - Fork 54
Improve new onboarding authentication screen #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| > | ||
| <span> | ||
| { __( 'New to WordPress.com?' ) }{ ' ' } | ||
| { __( "Don't have a WordPress.com account?" ) }{ ' ' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another suggestion that I have is maybe we can keep "New to WordPress.com?" because now we are repeating the same wording - "account" and "account - in within the distance of a couple of words
|
|
||
| <div> | ||
| { [ | ||
| __( 'Share preview sites with team members and clients.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| __( 'Share preview sites with team members and clients.' ), | |
| __( 'Share preview sites with clients and team members.' ), |
Just wanted to put "clients" first here as I think this is what most people care about in the first place
| <div> | ||
| { [ | ||
| __( 'Share preview sites with team members and clients.' ), | ||
| __( 'Seamless sync with WordPress.com and Pressable sites.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| __( 'Seamless sync with WordPress.com and Pressable sites.' ), | |
| __( 'Seamlessly sync with WordPress.com and Pressable sites.' ), |
Here, I am suggesting that we use a verb "sync" instead of a noun "sync" to be consistent with other items in the list that also use verbs
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for making these adjustments 👍 I think this will give WordPress.com more exposure within Studio
…1058-improve-onboarding-login-screen
📊 Performance Test ResultsComparing 73853be vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
|
All CI is green 🥲 |

Related issues
Proposed Changes
Testing Instructions
~/Library/Application Support/Studio/appdata-v1.jsonremove theonboardingCompletedand any authToken entry.npm startPre-merge Checklist