Change texts in authentication onboarding #2176
Conversation
sejas
changed the title
📊 Performance Test ResultsComparing 54d7a11 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gcsecsey
left a comment
gcsecsey
left a comment
There was a problem hiding this comment.
The updated copies LGTM 👍
| return this.locator.getByRole( 'heading', { | ||
| name: /Connect to your WordPress.com account|Connect your WordPress.com account/, | ||
| } ); | ||
| return this.locator.getByTestId( 'onboarding-welcome-title' ).or( |
There was a problem hiding this comment.
Not something that should be done, I am just thinking for the future cases - are there some disadvantages of using data-testid vs roles 🤔 Interesting your thoughts why you decided to switch to testid?
There was a problem hiding this comment.
I decided to use testId because this flow is used in every e2e and performance metric, so changing the text becomes more tricky as we need to support both text for a bit. Using only role could work, but I want to make sure the Heading displayed is this one and not the Add site flow.
I'll remove the text selector after a few days in favor of the testId.
sejas
deleted the
update/stu-1083-studio-change-the-texts-in-authentication-onboarding
branch
Related issues
Proposed Changes
Testing Instructions
onboardingCompletedfrom your~/Library/Application Support/Studio/appdata-v1.jsonnpm startPre-merge Checklist