Clean setSelectedRemoteSite when closing modal

[sejas]

Related issues

• Fixes STU-1121
• Similar fix to Reset file import state on Add site modal close #2220
• We made the AddSite state persistent, even if the modal closes or unmounts in Add Site modal: make sure deeplink hook is always mounted #2201

Proposed Changes

• Clean the selected remote site after closing the modal to fix the issue where new created sites were pulling without selecting that path.

Testing Instructions

• Run npm start
• Click on Add site
• Select Pull an existing site
• Finish the process
• Click on Add site again
• Select a blank site
• Observe it creates a blank site and it doesn't pull anything

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[ivan-ottinger]

Thank you for the fix, Antonio! The change looks good and I cannot reproduce the issue anymore. No unexpected pull happens on creating a new site.

[gcsecsey]

Thanks for quickly raising a fix Antonio! The changes LGTM too, and I can also confirm not being able to reproduce the original issue. I also tested opening deeplinks, which now also works as expected, no site is being pulled again. 👍

[github-actions]

📊 Performance Test Results

Comparing 0f7a8fe vs trunk

site-editor

Metric	trunk	0f7a8fe	Diff	Change
load	10844.00 ms	20047.00 ms	+9203.00 ms	🔴 84.9%

site-startup

Metric	trunk	0f7a8fe	Diff	Change
siteCreation	22750.00 ms	22777.00 ms	+27.00 ms	🔴 0.1%
siteStartup	11030.00 ms	8022.00 ms	-3008.00 ms	🟢 -27.3%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change