Skip to content

Conversation

@katinthehatsite
Copy link
Contributor

@katinthehatsite katinthehatsite commented Dec 10, 2025

Related issues

Fixes STU-1076

Proposed Changes

This PR ensures that Studio app can be dragged by the top header when the user is on the Add site screen:

Screenshot 2025-12-11 at 9 45 38 AM

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • Click on Add site
  • Confirm that you can drag the app by the header

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Dec 10, 2025
@katinthehatsite katinthehatsite marked this pull request as draft December 10, 2025 14:18
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📊 Performance Test Results

Comparing 043bb7b vs trunk

site-editor

Metric trunk 043bb7b Diff Change
load 9074.00 ms 10789.00 ms +1715.00 ms 🔴 18.9%

site-startup

Metric trunk 043bb7b Diff Change
siteCreation 23404.00 ms 22542.00 ms -862.00 ms 🟢 -3.7%
siteStartup 10115.00 ms 9079.00 ms -1036.00 ms 🟢 -10.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@katinthehatsite
Copy link
Contributor Author

This will make the behaviour of the app consistent with other screens. One thing is that we don't have any visual indication where the header is on that screen but we would need reconsider design for that case.

@katinthehatsite katinthehatsite marked this pull request as ready for review December 11, 2025 08:49
@katinthehatsite katinthehatsite requested a review from a team December 11, 2025 08:55
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katinthehatsite for fixing this! I have tested it, and it works as expected, I can move the Studio window when I'm adding a site. LGTM!

CleanShot.2025-12-11.at.10.22.38.mp4

Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works as expected. LGTM 👍

CleanShot.2025-12-11.at.15.02.10.mp4

@katinthehatsite katinthehatsite merged commit b401bb6 into trunk Dec 11, 2025
10 checks passed
@katinthehatsite katinthehatsite deleted the fix/make-add-site-screen-draggable branch December 11, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants