Skip to content

Conversation

@gavande1
Copy link
Contributor

…ation process when access is denied.

Related issues

Proposed Changes

  • Display specific error message to the user when authorization is explicitly denied by them while login into Studio.

Testing Instructions

  • Switch to this branch
  • Run npm start
  • If you’re already logged into WordPress.com, log out
  • Click Log In
  • When the OAuth page opens up, click on Deny
  • You’ll be taken back to the Studio with a message saying you denied the request
Before After
CleanShot 2025-12-11 at 19 22 13@2x CleanShot 2025-12-11 at 19 21 49@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 changed the title Auth: Display specific message to the user to approve the authorization when access is denied Auth: Display authorization denied message to the user access is denied Dec 11, 2025
@gavande1 gavande1 self-assigned this Dec 11, 2025
@gavande1 gavande1 requested a review from a team December 11, 2025 14:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

📊 Performance Test Results

Comparing 191af6d vs trunk

site-editor

Metric trunk 191af6d Diff Change
load 13281.00 ms 11834.00 ms -1447.00 ms 🟢 -10.9%

site-startup

Metric trunk 191af6d Diff Change
siteCreation 19444.00 ms 21328.00 ms +1884.00 ms 🔴 9.7%
siteStartup 8014.00 ms 8029.00 ms +15.00 ms 🔴 0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! The code looks good. I have left a copy suggestion.

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this @gavande1! I have tested it, and I can see now the new message, which sounds less scary. I agree with the suggestion from @ivan-ottinger, but overall this LGTM!

Image

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I left some suggestions for the copy.

@gavande1 gavande1 merged commit 60e4ece into trunk Dec 12, 2025
10 checks passed
@gavande1 gavande1 deleted the stu-1103-studio-deny-button-is-broken-on-studio branch December 12, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants