Avoid showing a path conflict when pulling a remote site multiple times

[sejas]

Related issues

• Fixes STU-1118

Proposed Changes

• When pulling an existing remote site multiple times, the user received an error conflicting in the path. In this PR I suggest appending a suffix number to generate a new clean path.

Testing Instructions

• Run npm start
• Click on Add site and then select Pull an existing site
• Continue and create the site
• Observe that the site name does not contain any numeric suffix.
• Repeat the operation selecting the same site.
• Observe that the generated name is "Sitename 2" so it doesn't show any error to the user.

Before	After

pull-site-twice.mp4

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[epeicher]

Thanks @sejas for solving this! I have had that issue in the past, and I thought that receiving an error was not a great UX, so I like this!

I have tested it, and it works as expected, I can see the sites with the number added and increasing. I have left a couple of minor comments, but this LGTM!

Existing site	Selecting the same site	Suffix added	Suffix increased for subsequent sites

[epeicher]

I think we can remove the async keyword from here

[epeicher]

Now that we have moved this createSiteProps.handleSiteNameChange( availableName ) to an async function, maybe we can get rid of the void operator and replace it for an await? I think we should minimize the use of void to very specific use cases. But this is my personal opinion, happy to leave it as is, as it was the previous behavior.

[sejas]

Changed it here 141c3f2

[github-actions]

📊 Performance Test Results

Comparing 936222c vs trunk

site-editor

Metric	trunk	936222c	Diff	Change
load	9732.00 ms	13976.00 ms	+4244.00 ms	🔴 43.6%

site-startup

Metric	trunk	936222c	Diff	Change
siteCreation	21606.00 ms	20423.00 ms	-1183.00 ms	🟢 -5.5%
siteStartup	8991.00 ms	8986.00 ms	-5.00 ms	🟢 -0.1%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[katinthehatsite]

The changes look good to me, I am not seeing any regressions and the code reads well as well 👍