Render app arch inside About dialog #2244
Conversation
src/about-menu/open-about-menu.ts
Outdated
| document.title = '${ aboutStudioText }'; | ||
| document.getElementById('studio-by-wpcom').innerText = '${ studioByWpcomText }'; | ||
| document.getElementById('version-text').innerText = '${ versionText }'; | ||
| document.getElementById('version-text').title = '${ systemInfoTooltip }'; |
There was a problem hiding this comment.
Actually, this information is essential for debugging, and it would be great if users could copy-paste it. What if we included it inline, in brackets, after the version?
There was a problem hiding this comment.
What if we included it inline
I am totally on board with it. Actually, it was what I did initially, but then decided to hide 😄
src/about-menu/open-about-menu.ts
Outdated
| const arch = process.arch; | ||
|
|
||
| if ( platform === 'darwin' ) { | ||
| return arch === 'arm64' ? 'macOS Apple Silicon' : 'macOS Intel'; |
There was a problem hiding this comment.
What if we aligned those options with the exact wording we use on the landing page?
📊 Performance Test ResultsComparing d6456eb vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
You should be able to trigger a build on CI and reviewers could use the generated artifacts to validate the changes without needing to build locally. |
|
I printed arch and made the line selectable. |
wojtekn
left a comment
wojtekn
left a comment
There was a problem hiding this comment.
Looks good:
| Apple Silicon Chip | Intel Chip |
|---|---|
 |
 |
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
I tested it on Mac and it works as expected. I tested it in English and Spanish.
| English | Spanish |
|---|---|
 |
 |
Proposed Changes
I am working on STU-1069, and I didn't know how to determine whether the arm version is installed or not. I had an assumption that maybe the bug is on the frontend and it's just UI bug. I decided that would be usefull to somewhere render the arch. So I added it as a title for the Studio version, to avoid being intrusive in the dialog. I think it will be useful for our team in the future.
Testing Instructions