-
Notifications
You must be signed in to change notification settings - Fork 54
Update WordPress Components packages to latest versions #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "wpcom-xhr-request": "^1.3.0", | ||
| "yargs": "^18.0.0", | ||
| "yauzl": "^3.2.0", | ||
| "zod": "^3.24.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcotrim, it seems NPM keeps them organized, sorted by name, so I think we may leave it as is instead of trying to position the Playground packages at the end.
📊 Performance Test ResultsComparing 1b1ec8e vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
ivan-ottinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the build and there don't seem to be any regressions. I tried with RTL locale as well and clicked through the UI. Nothing stood out of place. 👍🏼
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 👍
gavande1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this and nothing seems to broken in term of UI. LGTM 👍
Related issues
Proposed Changes
I propose to update WordPress Components to the latest versions.
Testing Instructions
Pre-merge Checklist