Skip to content

Conversation

@nightnei
Copy link
Contributor

@nightnei nightnei commented Dec 17, 2025

Related issues

Proposed Changes

With this PR we are starting using the new property (studioArch) to provide Studio's arch to Squirrel, since arch is patched by Squirrel and it fails arm64 Windows version updates.

Testing Instructions

  1. Change Studio version in package.json to e.g. 1.6.2 and run npm i
  2. Install and update Studio:
Before update After update
Windows (Parallels)
npm run make:windows-arm64
Here we previously had bug, it was updated to Intel instead of Arm
Screenshot 2025-12-18 at 16 07 22 Screenshot 2025-12-18 at 16 08 28
Windows (Parallels)
npm run make:windows-x64
Screenshot 2025-12-18 at 16 31 59 Screenshot 2025-12-18 at 16 33 06
  1. Now let's switch to trunk (keep the changed package.json from the 1-st step) and repeat the same two commands for Windows to make sure that the nearest Studio release will work as expected. Keep in mind that currently Studio doesn't have the new studioArch property, so the nearest first release will still be updated incorrectly - switching from arm to intel version. But then all releases will be good, since Studio will use studioArch.
    3.1 Intel -> Intel
    3.2 Arm -> Intel (As was mentioned above, 1 release will still have bug)
  2. macOS - testing macOS is more dificult than Windows (details - STU-1069#comment-db7c4f2b), so you can go just with this artifact which I build, it's enough to test only one this case, to confirm that everything works with studioArch and arch can be ignored.

@nightnei nightnei self-assigned this Dec 17, 2025

update_builds = {
x64: {
binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-x64', 'Studio.app.zip'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed tabs, nothing changed here

@nightnei nightnei marked this pull request as ready for review December 18, 2025 18:51
@nightnei nightnei requested a review from a team December 18, 2025 19:42
@ivan-ottinger
Copy link
Contributor

I am going to review this PR.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, Vova! The change looks good and I have tested all scenarios. The updates went well in all cases.

It took a bit longer as I run into issues with the build process (not related to the PR) and it took ages for the Windows builds to finish.

Windows

Update with the PR branch

ARM:

Before app update After app update
Image Image

Intel/AMD:

Before app update After app update
Image Image

Update with the trunk branch

ARM:

Before app update After app update (gets updated to the incorrect architecture - as expected)
Image Image

Intel/AMD:

Before app update After app update
Image Image

macOS

Using the provided build:

Before app update After app update
Image Image

@nightnei
Copy link
Contributor Author

nightnei commented Dec 19, 2025

@ivan-ottinger , thank you so much for thorough testing ❤️

It took a bit longer as I run into issues with the build process (not related to the PR)

Same

it took ages for the Windows builds to finish

Yeah, build process on Windows really takes a lot of time in comparison with macOS. Additionally when you develop, testing and iterate 😅

Sorry that you spent a lot of time, and thanks for sharing my pain 😁🤗

@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 23188cd vs trunk

site-editor

Metric trunk 23188cd Diff Change
load 9886.00 ms 10454.00 ms +568.00 ms 🔴 5.7%

site-startup

Metric trunk 23188cd Diff Change
siteCreation 17302.00 ms 19476.00 ms +2174.00 ms 🔴 12.6%
siteStartup 6997.00 ms 8008.00 ms +1011.00 ms 🔴 14.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@ivan-ottinger
Copy link
Contributor

Sorry that you spent a lot of time, and thanks for sharing my pain 😁🤗

Hehe, no worries! I did other things while it was building. 😄

@nightnei nightnei merged commit 040526e into trunk Dec 19, 2025
10 checks passed
@nightnei nightnei deleted the fixStudioUpdaterOnWindows branch December 19, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants