-
Notifications
You must be signed in to change notification settings - Fork 54
Fix Studio updater on Windows #2280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| update_builds = { | ||
| x64: { | ||
| binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-x64', 'Studio.app.zip'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed tabs, nothing changed here
|
I am going to review this PR. |
ivan-ottinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, Vova! The change looks good and I have tested all scenarios. The updates went well in all cases.
It took a bit longer as I run into issues with the build process (not related to the PR) and it took ages for the Windows builds to finish.
Windows
Update with the PR branch
ARM:
| Before app update | After app update |
|---|---|
![]() |
![]() |
Intel/AMD:
| Before app update | After app update |
|---|---|
![]() |
![]() |
Update with the trunk branch
ARM:
| Before app update | After app update (gets updated to the incorrect architecture - as expected) |
|---|---|
![]() |
![]() |
Intel/AMD:
| Before app update | After app update |
|---|---|
![]() |
![]() |
macOS
Using the provided build:
| Before app update | After app update |
|---|---|
![]() |
![]() |
|
@ivan-ottinger , thank you so much for thorough testing ❤️
Same
Yeah, build process on Windows really takes a lot of time in comparison with macOS. Additionally when you develop, testing and iterate 😅 Sorry that you spent a lot of time, and thanks for sharing my pain 😁🤗 |
📊 Performance Test ResultsComparing 23188cd vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Hehe, no worries! I did other things while it was building. 😄 |










Related issues
Proposed Changes
With this PR we are starting using the new property (
studioArch) to provide Studio's arch to Squirrel, sincearchis patched by Squirrel and it fails arm64 Windows version updates.Testing Instructions
npm inpm run make:windows-arm64
Here we previously had bug, it was updated to Intel instead of Arm
npm run make:windows-x64
trunk(keep the changed package.json from the 1-st step) and repeat the same two commands for Windows to make sure that the nearest Studio release will work as expected. Keep in mind that currently Studio doesn't have the newstudioArchproperty, so the nearest first release will still be updated incorrectly - switching from arm to intel version. But then all releases will be good, since Studio will usestudioArch.3.1 Intel -> Intel
3.2 Arm -> Intel (As was mentioned above, 1 release will still have bug)
studioArchandarchcan be ignored.