Python 3 support merged from Kanghyojun #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous version of s2protocol, it prints error message like this `print >> sys.stderr`. But i missed it to print on `sys.stderr`
jrepp
changed the title
ccheever
pushed a commit
to ccheever/s2protocol
that referenced
this pull request
Jan 24, 2026
* Ignore tox directory * Use tox & minor improve in setup.py * Replace `ord` depends on Python version * Replace ord into byte_to_int [Compatibility] * Prefer .format over % syntax * Prefer range over xrange * Use print function * Prefer .items() over .iteritems() * Remove six * Run tox with tox-travis * Catch `Exception as e` rather than Exception, e * The binary type includes int * xrange → range in README.md * Using print function from __future__ in s2_cli * Adding cli script call to travis.yml * Fixing NDJSON output * Add s2_cli.py to entry_point * Use byte literal for compatibility * Implement Python3 compatible json.dumps * Run cli test on tox already * .iteritems() → .items() * Print error using sys.stderr In previous version of s2protocol, it prints error message like this `print >> sys.stderr`. But i missed it to print on `sys.stderr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged together changes from master and Kanghyojun into a single new PR