feat: git branches nesting#1571
Conversation
8ae6966 to
0e1b4b4
Compare
austincondiff
left a comment
There was a problem hiding this comment.
Please fix the SwiftLine errors before we can merge.
|
@FezVrasta : Can you take a screenshot of what appears when you go to the website? |
|
What do you mean? What website? |
|
@FezVrasta : If you look at the screenshot you posted it says website and a side menu should open. |
|
@Angelk90 I think @FezVrasta has provided sufficient details for this PR. |
|
@austincondiff : See where it says docs, the menu on the right opens and the word docs/ggc-sponsor appears, the repetition of the word docs in that case seems useless to me, yes since I'm on docs, I wanted to see if it also happened in the other cases. |
|
@FezVrasta thanks for the PR! Got some questions: 1: Can we use the popover? I really like its style:
|
0e1b4b4 to
f15c2a4
Compare
457a202 to
caaf178
Compare
|
@FezVrasta: Great, what happens if there is only one branch and it is the selected one. In the future I would propose to change the branch icon, I would propose like that of xcode. |
I haven't changed that behavior so it will work like it does today. |
|
This looks fantastic @FezVrasta! I would agree, we have a "branch" symbol in CodeEditSymbols that you might use instead. |
caaf178 to
172336d
Compare
austincondiff
left a comment
There was a problem hiding this comment.
Great work @FezVrasta! 👏
|
@austincondiff , @FezVrasta : It would be possible to change the icon here too and add the same one that was used for the branch as xcode does. |
172336d to
7c7a8a7
Compare
|
@FezVrasta : Great. |
|
@FezVrasta : I join @activcoding's proposal, do you think it's too demanding? |
I reckon the popover style is more important. We can throw in those finer details in a later PR |
|
Yeah, let's merge this PR. We are scope creeping quite a bit here imo. Looks good enough to merge. |
|
@activcoding : If anything, can you try to add these details yourself? |
I used the Menu component because it has built-in keyboard support, we can definitely use the Popover but I think we'll have to build keyboard support from scratch? |
Ok, great choice going with the Menu component. Your work looks fantastic—let's get this merged! If @austincondiff adds me as a reviewer, I'd be more than happy to go through your changes. |
I don't like your tone here; it feels a bit demanding. Nevertheless, I've got a lot on my plate with a few PRs in progress. Once those are sorted, I'll definitely take a look at the issue. |
|
@activcoding : He didn't want to be, I really liked your idea. |












Description
Implements Git branches grouping using the first slash as prefix separator. This allows for easier navigation on large repositories that prefix branches (for example:
feat/some-feature)This PR builds on top of #1570
Related Issues
Checklist
Screenshots