Workspace settings

[armartinez]

Description

This PR adds the base implementation for the workspace settings, which are created on the ./codeedit/ hidden folder inside the base path of the workspace once one of the settings is changed. Currently it just shows the general and tasks settings into a single sheet and the stored settings are not being used elsewhere.

Related Issues

• Activity Viewer  #1592

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

[austincondiff]

@armartinez Looks good from what I can tell. Please resolve swift lint errors though.

[0xWDG]

The changes for the packages do not work with the tests, can you revert those so the tests can be run. Thanks!

[0xWDG]

🎉🚀

[tom-ludwig]

Thanks for your amazing changes!

Some other issues I found while trying out the settings:

• If a user has the workspace settings open, he would still be able to click into the editor without the window disappearing. I think this would be fixed by using a sheet instead of a custom window.
• The “Tasks” toggle is not descriptive enough. Does the toggle indicate whether the task should be executed? Maybe a tooltip would help
• Environment variables should be deleted when pressing backspace;
• It seems there is an issue with the Environment Variable View, not sure if this is fixable:

[armartinez]

Thanks for your amazing changes!

Some other issues I found while trying out the settings:

• If a user has the workspace settings open, he would still be able to click into the editor without the window disappearing. I think this would be fixed by using a sheet instead of a custom window.
• The “Tasks” toggle is not descriptive enough. Does the toggle indicate whether the task should be executed? Maybe a tooltip would help
• Environment variables should be deleted when pressing backspace;
• It seems there is an issue with the Environment Variable View, not sure if this is fixable:

• I'm aiming for the same behaviour as the normal settings which are also a window.
• Sure I can add some comment.
• Can you be more specific about the issue in the env variables view ?

[tom-ludwig]

@armartinez, it kinda looks off, doesn't it? I think it's the blue highlighting. No need to worry about this small design thing now; we can fix it later. I can be a bit to picky sometimes 😁

[tom-ludwig]

LGTM

We should definitely take a look at how we can make better use of SwiftLint.

[FastestMolasses]

LGTM

[austincondiff]

@allcontributors add @armartinez for code

[allcontributors]

@austincondiff

I've put up a pull request to add @armartinez! 🎉