perf(search): Resolved issue with SearchKit#1688
Merged
matthijseikelenboom merged 4 commits intoCodeEditApp:mainfrom May 1, 2024
Merged
perf(search): Resolved issue with SearchKit#1688matthijseikelenboom merged 4 commits intoCodeEditApp:mainfrom
matthijseikelenboom merged 4 commits intoCodeEditApp:mainfrom
Conversation
…g when queries contained special characters.
Member
Author
|
Finally ready for review. It was tougher to come up with those 21 lines than the original 400. Good thing I found a bug during testing, which I've fixed now. Could you guys test some queries on your projects to make sure everything's working right? |
Contributor
|
Might want to put some XCTests in place as well? |
FastestMolasses
previously approved these changes
Apr 29, 2024
FastestMolasses
approved these changes
Apr 30, 2024
matthijseikelenboom
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the search algorithm was unable to process certain special characters (e.g.
,,(,*,:). This limitation prevented users from finding content that included these characters in their queries.For example, searching for "info": in a JSON file would not return any results due to this limitation.
Contents.json:
{ "info": "xcode": { [...] } }The fix in this PR corrects the search algorithm to handle these special characters, allowing users to successfully search for content that includes them.
Related Issues
na
Checklist
Screenshots