Project navigator file filtering#1896
Merged
austincondiff merged 9 commits intoCodeEditApp:mainfrom Oct 7, 2024
Merged
Conversation
Collaborator
|
Wow this looks awesome! I should have time to review very soon. Excited for this! |
thecoolwinter
requested review from
0xWDG,
KaiTheRedNinja,
austincondiff,
matthijseikelenboom,
thecoolwinter and
tom-ludwig
austincondiff
requested changes
Oct 3, 2024
Collaborator
There was a problem hiding this comment.
This is incredible work @LeonardoLarranaga! Two quick UI-related tweaks:
- When "No Filter Results" appears as a result of not having any results, we should hide the root folder as well.
- When filter text is present and if matches are found amongst files and/or folders, bolded text should have a primary label color and unbolded text should have a secondary label color. If parent folders are shown but do not have a match, than the unbolded text has a primary color.
thecoolwinter
requested changes
Oct 6, 2024
Collaborator
thecoolwinter
left a comment
thecoolwinter
left a comment
There was a problem hiding this comment.
A couple of quick changes.
CodeEdit/Features/Documents/WorkspaceDocument/WorkspaceDocument.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/StandardTableViewCell.swift
Outdated
Show resolved
Hide resolved
...Area/ProjectNavigator/OutlineView/ProjectNavigatorViewController+NSOutlineViewDelegate.swift
Outdated
Show resolved
Hide resolved
...dit/Features/NavigatorArea/ProjectNavigator/OutlineView/ProjectNavigatorViewController.swift
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/FileSystemTableViewCell.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/NavigatorArea/OutlineView/FileSystemTableViewCell.swift
Outdated
Show resolved
Hide resolved
…wCell.swift Co-authored-by: Khan Winter <[email protected]>
- Changed `workspace.filter` to `workspace.navigatorFilter` and added its respective comment. - Returned `StandardTableViewCell` to a weak reference of the workspace object. - Replaced the navigators own filter string with the workspace one and added throttle to the filter change. - When closing the window, if there is a search going on, all the items don't get saved expanded anymore.
austincondiff
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the ability to search files and folders in the navigator area. The following features were added:
Related Issues
Checklist
Screenshots
(From description list)
Screen.Recording.2024-10-03.at.02.52.30.mov
Screen.Recording.2024-10-03.at.02.53.06.mov
Screen.Recording.2024-10-03.at.02.54.05.mov
Screen.Recording.2024-10-03.at.02.55.53.mov