Skip to content

Conversation

@codingWithJimmy
Copy link
Contributor

Description

The current iteration of this command always produces a value of 0 when running it on Minecraft servers. Not sure if there was an issue with Gamedig on a previous version but that matter seems to be resolved with the version I am using which is 5.1.4. This request simply removes the 'if' statement related to Minecraft servers so it can use the same command as all the other servers.

Fixes #4724

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@codingWithJimmy codingWithJimmy changed the title Fix/4724 gamedig Update query_gamedig.sh to correct the of counting players online on Minecraft servers Jan 5, 2025
@dgibbs64 dgibbs64 added this to the v24.4.0 milestone Jan 5, 2025
@dgibbs64 dgibbs64 changed the title Update query_gamedig.sh to correct the of counting players online on Minecraft servers fix(mc): correct the of counting players online on Minecraft servers via gamedig Jan 5, 2025
@dgibbs64 dgibbs64 merged commit 6adf4da into GameServerManagers:develop Jan 5, 2025
3 checks passed
@codingWithJimmy codingWithJimmy deleted the fix/4724-gamedig branch January 5, 2025 17:55
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants