Use pico-args for arg parsing#31
Merged
KillingSpark merged 1 commit intoKillingSpark:masterfrom Mar 9, 2020
MggMuggins:master
Merged
Use pico-args for arg parsing#31KillingSpark merged 1 commit intoKillingSpark:masterfrom MggMuggins:master
KillingSpark merged 1 commit intoKillingSpark:masterfrom
MggMuggins:master
Conversation
I'm not sure if this is really much better than it was before, it would be handy for the parse_args func to do all the validation and pass back a consistent error type with a possibility for some other errors wrapped up in some of the variants. I ran the tests (not sure if they use the arg parsing or not :D), and tested with a couple of arg combos and it seems to work. Regardless of caveats, feel free to merge or close this PR, pico-args is just one option for arg-parsing. This code could also use improvement, I'm happy to incorporate feedback.
Owner
|
Thanks! Not having to worry about tedious arg parsing for future options is quite helpful :) |
Owner
|
I think the error variants is not too important right now. It would of course be nice but it's just polishing. |
Contributor
Author
|
Yeah, that's what I figured. Do ping me if it ever gets to a point when that would be required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is really much better than it was before, it would
be handy for the parse_args func to do all the validation and pass back
a consistent error type with a possibility for some other errors wrapped
up in some of the variants.
I ran the tests (not sure if they use the arg parsing or not :D), and
tested with a couple of arg combos and it seems to work.
Regardless of caveats, feel free to merge or close this PR, pico-args is
just one option for arg-parsing. This code could also use improvement,
I'm happy to incorporate feedback.