FIX: package libctranslate2.so in wheel to avoid build fail#1920
Merged
jordimas merged 3 commits intoOpenNMT:masterfrom Dec 4, 2025
Merged
FIX: package libctranslate2.so in wheel to avoid build fail#1920jordimas merged 3 commits intoOpenNMT:masterfrom
jordimas merged 3 commits intoOpenNMT:masterfrom
Conversation
Signed-off-by: yzewei <yangzewei@loongson.cn>
Merged
jordimas
reviewed
Nov 29, 2025
| elif sys.platform == "linux": | ||
| cflags.append("-fPIC") | ||
| ldflags.append("-Wl,-rpath,-Wl,-rpath,/usr/local/lib64") | ||
|
|
Collaborator
There was a problem hiding this comment.
Hello! Two comments:
- -Wl,-rpath is repeated twice in " ldflags.append("-Wl,-rpath,-Wl,-rpath"
- ,/usr/local/lib64 may not work in some distros that use /usr/local/lib
A better solution may be:
ldflags.append("-Wl,-rpath,/usr/local/lib64:/usr/local/lib")
jordimas
added a commit
to jordimas/CTranslate2
that referenced
this pull request
Dec 17, 2025
…1920) * package libctranslate2.so in wheel to avoid import errors Signed-off-by: yzewei <yangzewei@loongson.cn> * Fix based on PR discussion --------- Signed-off-by: yzewei <yangzewei@loongson.cn> Co-authored-by: Jordi Mas <jmas@softcatala.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, installing the ctranslate2 wheel may fail to find the libctranslate2 shared library, causing import errors.
This patch updates setup.py to include libctranslate2.so in the wheel via package_data for Linux.
For detailed error information, see the related issue: [issue#1919]