Add activation and dilation to conv1d#1979
Merged
jordimas merged 4 commits intoOpenNMT:masterfrom Jan 19, 2026
Merged
Conversation
Contributor
sssshhhhhh
commented
Jan 16, 2026
- Optional activation for conv1d to fuse with bias
- Dilation support for conv1d gpu
- Use gemm_batch_strided to run each conv1d group in a single kernel
Collaborator
|
Thanks. Have you done any benchmark on how performance is impacted? |
Contributor
Author
fp16 [4,1280,3000]*[1280,1280,3]=[4,1280,1500] |
Contributor
Author
|
Optimised im2col a bit, no bias/gelu down to 0.694081 |
Collaborator
|
Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.