Skip to content

Make row links proper a tags#2510

Merged
johnsimons merged 1 commit intomasterfrom
john/proper_a
Jul 11, 2025
Merged

Make row links proper a tags#2510
johnsimons merged 1 commit intomasterfrom
john/proper_a

Conversation

@johnsimons
Copy link
Member

So that we can easily open indivdual messages in a new tab.

Copy link
Contributor

@cquirosj cquirosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RouterLink Is a better option for sure. It will result in an anchor tag nesting the divs once it is rendered. But using the routerLink is always a better idea since it integrates with the router 👍

Maybe convert the divs to spans to be complaint 🤔

@johnsimons
Copy link
Member Author

@cquirosj I misread the html specs, aparently HTML5 does support divs inside a tags

@johnsimons johnsimons merged commit 69b3e98 into master Jul 11, 2025
5 of 7 checks passed
@johnsimons johnsimons deleted the john/proper_a branch July 11, 2025 05:15
@DavidBoike DavidBoike added the Type: Improvement Type: Improvement label Jul 31, 2025
@DavidBoike DavidBoike added this to the 2.1.1 milestone Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Improvement Type: Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants