Menu icon tooltips not displaying as expected via FontAwesome title attribute#2615
Merged
Menu icon tooltips not displaying as expected via FontAwesome title attribute#2615
Conversation
DharmishthaVPatel
approved these changes
Sep 3, 2025
danielmarbach
approved these changes
Sep 3, 2025
Contributor
|
Nice didn't know we had this installed |
Contributor
danielmarbach
left a comment
danielmarbach
left a comment
There was a problem hiding this comment.
Relatively new to this, so be patient with me ;)
Isn't this the correct syntax?
src/Frontend/src/components/configuration/ConfigurationMenuItem.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/customchecks/CustomChecksMenuItem.vue
Outdated
Show resolved
Hide resolved
src/Frontend/src/components/failedmessages/FailedMessagesMenuItem.vue
Outdated
Show resolved
Hide resolved
soujay
changed the title
danielmarbach
approved these changes
Sep 4, 2025
Contributor
|
i realise it has already been merged, but it makes more sense to me to leave the prop on FAIcon as title, and have the FAIcon component turn that into a v-tippy attribute on the actual FontAwesomeIcon |
Contributor
|
@PhilBastian That makes sense from an encapsulation perspective 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu icons were expected to show tooltips via the 'title' prop passed to the FontAwesome Vue component. However, the internal SVG <title> tag did not trigger native browser tooltips as intended.
This PR replaces the use of 'title' with Tippy.js to ensure consistent tooltip behavior across browsers and improve accessibility. Tooltips now appear reliably on hover.