Conversation
johnsimons
force-pushed
the
john/replace_moment
branch
from
4a564d8 to
a54167b
Compare
This should save ~286KB gzipped
johnsimons
force-pushed
the
john/replace_moment
branch
from
a54167b to
9dbd142
Compare
PhilBastian
approved these changes
Nov 26, 2025
| const { config: edit_and_retry_config } = storeToRefs(editRetryStore); | ||
| const { configuration } = storeToRefs(configStore); | ||
| const error_retention_period = computed(() => moment.duration(configuration.value?.data_retention?.error_retention_period).asHours()); | ||
| const error_retention_period = computed(() => dayjs.duration(configuration.value?.data_retention?.error_retention_period ?? "PT0S").asHours()); |
Contributor
There was a problem hiding this comment.
it's not obvious what the fallback default means
Member
Author
There was a problem hiding this comment.
Well, it is documented in the api docs. Do you think that is enough?
I didn't want to add a comment for something that is in the docs.
johnsimons
added
Type: Refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated from moment.js (2.30.1) to Day.js for date/time handling, reducing bundle size by ~68KB gzipped (~94% reduction) with zero breaking changes to functionality.
Motivation