Speedup cold runs of PSSA by using a runspace pool and parallelizing the slowest rule (AvoidAlias)#1178
Merged
JamesWTruher merged 8 commits intoPowerShell:developmentfrom Jun 5, 2019
Conversation
…ng PowerShell for CommandInfo. There are only 4 rules that could call the CommandInfoCache, therefore sizing the pool to 5. The pool creation is synchronous and adds 15ms of initialization overhead, which we can neglect I think.
…nsive command lookup in AvoidAlias, which is the most expensive rule. To accomodate the higher parallel demand, increase runspace pool.
rjmholt
reviewed
Apr 15, 2019
Co-Authored-By: bergmeister <c.bergmeister@gmail.com>
…nalyzer into Performance_RunspacePool_AndSpeedupAvoidAlias Resolved by taking upstream changes # Conflicts: # Rules/AvoidAlias.cs
JamesWTruher
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We can decide to defer this performance improvement PR after the 1.18.0 release (or maybe merge only the runspace improvement?)
In total this can cut the time in half of analyzing a big script like e.g. build.psm1 the first time in a new shell.
AvoidAliasrule is the slowest rule. The slowness comes from a lot of calls to the command info cache, therefore this part is being parallelized and the runspace pool count is increased to 10 for that. This leads to a 30% improvement. The rule execution times before in this paraellization improvement changed the longest running rule from 7884 ms to 5164 (they are run in parallel, therefore the slowest rule is the weakest link):I did measure of course multiple times, the numbers are just an example of an average/normal run
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.