Fix formatting regression in 1.18.0 whereby single-line pipeline reduces indentation level incorrectly#1191
Merged
bergmeister merged 4 commits intoPowerShell:developmentfrom Mar 28, 2019
Conversation
…rrectly (problem only showed up when there was already existing indentation due to ClipNegative
rjmholt
reviewed
Mar 25, 2019
Co-Authored-By: bergmeister <c.bergmeister@gmail.com>
Collaborator
Author
|
I applied the suggestions, I have to look at the test failures though, locally it was fine. |
rjmholt
approved these changes
Mar 25, 2019
JamesWTruher
approved these changes
Mar 26, 2019
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
it looks like this isn't quite right based on test failures
…nalyzer into FixUseConsistentIndentationBugWithSingleLinePipeline
…oop and not switch statement), simple mistake
Collaborator
Author
|
@rjmholt @JamesWTruher @TylerLeonhardt I fixed the build, it was a simple mistake, I used a |
rjmholt
approved these changes
Mar 28, 2019
This was referenced Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1187 by excluding single-line pipelines to avoid reduce indentation level incorrectly. This case showed up only when there is already some indentation.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.