Fix UseCompatibleSyntax class error message#1215
Merged
JamesWTruher merged 1 commit intoPowerShell:developmentfrom Apr 23, 2019
Merged
Fix UseCompatibleSyntax class error message#1215JamesWTruher merged 1 commit intoPowerShell:developmentfrom
JamesWTruher merged 1 commit intoPowerShell:developmentfrom
Conversation
bergmeister
approved these changes
Apr 15, 2019
Collaborator
There was a problem hiding this comment.
Good spot. Looks good to me.
Optional suggestion would be to create a wrapper function for creating the error message since there are now 6 usages of Strings.UseCompatibleSyntaxError, this would improve readability when using named parameters to call it and would also add a small safety net since one only sees a mismatch of number of parameter at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A bug in the UseCompatibleSyntax rule means error messages come out looking very bad. This fixes that.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.