Replace words with racial connotation (use allowlist and blocklist as an alternative)#1604
Merged
rjmholt merged 2 commits intoPowerShell:masterfrom Nov 3, 2020
Conversation
rjmholt
reviewed
Nov 3, 2020
Contributor
rjmholt
left a comment
There was a problem hiding this comment.
My only worry here is that this is a public configuration key, so that changing its name will break existing configurations
Contributor
Oh I see from your description that this is an alternative! |
rjmholt
approved these changes
Nov 3, 2020
Collaborator
Author
|
Yes, it is an alternative/alias for the existing settings but once a new version of pssa is released with that, which would give people time to adapt I am tempted to remove the original setting name completely in the following release but that's a discussion for another day, which will probably not happen until in 6 months time.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This does not replace all words with a racial connotation because one word is the setting name of the
PSAvoidUsingCmdletAliasesrule. Therefore an alternative setting name is being added, whilst allowing the current one to still work. The idea is that we give users time to adapt in the next version but completely remove the setting with a racial connotation in the version after that.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.