move to new signing process for release build and prep for 1.20.0#1625
Merged
rjmholt merged 36 commits intoPowerShell:masterfrom Apr 22, 2021
Merged
move to new signing process for release build and prep for 1.20.0#1625rjmholt merged 36 commits intoPowerShell:masterfrom
rjmholt merged 36 commits intoPowerShell:masterfrom
Conversation
bergmeister
reviewed
Jan 14, 2021
Add binskim scan directory
Also publish nupkg directly from signed directory
and don't publish the out directory, publishing the signed directory is enough
Fix up path for binskim
Also try to publish just the nupkg
JamesWTruher
force-pushed
the
releaseBuild002
branch
from
5e9cb36 to
b6415c3
Compare
Contributor
Author
|
I've rebased to be up to date. @bergmeister, @rjmholt, @SydneyhSmith - Chris is suggesting that our next release should perhaps be number |
rjmholt
approved these changes
Feb 10, 2021
Contributor
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
LGTM -- agree that 1.20 seems good
bergmeister
changed the title
bergmeister
approved these changes
Feb 10, 2021
rjmholt
approved these changes
Apr 21, 2021
Contributor
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
Generally looks good, just a small comment about the Write-Host invocations
Co-authored-by: Robert Holt <[email protected]>
rjmholt
reviewed
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The infrastructure at MS has changed with regard to signing, this PR allows us to use it.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.