Make UseSingularNouns rule work on PowerShell Core#1627
Merged
rjmholt merged 46 commits intoPowerShell:masterfrom Apr 28, 2021
Merged
Make UseSingularNouns rule work on PowerShell Core#1627rjmholt merged 46 commits intoPowerShell:masterfrom
rjmholt merged 46 commits intoPowerShell:masterfrom
Conversation
Collaborator
|
Ah unfortunately, the fact that the package is unlicensed does block us from accepting it |
Collaborator
Author
|
Ok, will contact the author if an MIT license or something similar can be added as it was probably not intentional by the author. Would the licence need to be on the NuGet package or just the source repo? |
Collaborator
Author
|
@SydneyhSmith I updated it to use the |
Collaborator
|
Thanks @bergmeister that package looks good to us |
rjmholt
reviewed
Feb 17, 2021
47150bf to
9327e6f
Compare
1402a5e to
5832be4
Compare
rjmholt
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1626
This uses the open source
Pluralize.NETNuGet package, which uses the MIT licence. The added payload is only 20KB once.Also enhance existing code to not construct
Pluralizationservicein foreach loop.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.