Merged
Conversation
clcaldwell
force-pushed
the
fix_build_module_tests
branch
from
6c91585 to
7ed3b09
Compare
JamesWTruher
approved these changes
Mar 30, 2021
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
thanks for this, this seems to be fine. Interestingly, I wasn't getting any failures on MacOS. Can you let me know which platform was having the problem?
rjmholt
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1653
Fix failing tests in BuildModules.tests.ps1 .
Move the tests into /Build/ in the central tests dir.
Add a reference to include the new folder path when executing all tests.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.