Fix PSUseConsistentIndentation.PipelineIndentation.None to not remove code when the previous line ended with a pipe

[bergmeister]

PR Summary

Fixes #1580 by resetting the newline in the case of the first token after a pipeline and newline lands in the default switch statement. It seems the existing test case was too simple.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
• Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

[andyleejordan]

Thank you for working on this @bergmeister. I'm wondering if we need a few more tests? #1580 provided several examples, and also pointed out that this issue occurs with both None and strangely a setting of 3. What do you think?

I can spend some time to manually test this if you'd like and perhaps come up with more test coverage.

[bergmeister]

Yes, testing is always a challenge. It's a compromise between doing lots of integration tests or complex code and maintaining all the test cases if a change necessitates updating expectations. Definitely happy to add more test cases or something more complex, do you have something specific in mind? Otherwise my suggestions is to dog food the local build with this setting.
With regards to the repro also working for 3, this is in fact the same setting, it is just the enum representation of it:

PSScriptAnalyzer/Rules/UseConsistentIndentation.cs

Lines 61 to 95 in 58c4423

	[ConfigurableRuleProperty(defaultValue: "IncreaseIndentationForFirstPipeline")]
	public string PipelineIndentation
	{
	get
	{
	return pipelineIndentationStyle.ToString();
	}
	set
	{
	if (String.IsNullOrWhiteSpace(value) ||
	!Enum.TryParse(value, true, out pipelineIndentationStyle))
	{
	pipelineIndentationStyle = PipelineIndentationStyle.IncreaseIndentationForFirstPipeline;
	}
	}
	}
	private bool insertSpaces;
	private char indentationChar;
	private int indentationLevelMultiplier;
	// TODO Enable auto when the rule is able to detect indentation
	private enum IndentationKind {
	Space,
	Tab,
	// Auto
	};
	private enum PipelineIndentationStyle
	{
	IncreaseIndentationForFirstPipeline,
	IncreaseIndentationAfterEveryPipeline,
	NoIndentation,
	None
	}

[andyleejordan]

With regards to the repro also working for 3, this is in fact the same setting, it is just the enum representation of it:

Gotcha! In that case, I'll defer to your judgement. Looks good to me!